Skip to content
This repository has been archived by the owner. It is now read-only.

8279195: Document the -XX:+NeverActAsServerClassMachine flag #71

Closed
wants to merge 1 commit into from

Conversation

vnkozlov
Copy link

@vnkozlov vnkozlov commented Dec 24, 2021

This product flag provides a way to emulate the old "Client VM" but has never been documented in the java command reference (aka manpage). It should be documented.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8279195: Document the -XX:+NeverActAsServerClassMachine flag

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18 pull/71/head:pull/71
$ git checkout pull/71

Update a local copy of the PR:
$ git checkout pull/71
$ git pull https://git.openjdk.java.net/jdk18 pull/71/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 71

View PR using the GUI difftool:
$ git pr show -t 71

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk18/pull/71.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 24, 2021

👋 Welcome back kvn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Dec 24, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 24, 2021

@vnkozlov To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@vnkozlov
Copy link
Author

@vnkozlov vnkozlov commented Dec 24, 2021

/label add hotspot

@openjdk openjdk bot added the hotspot label Dec 24, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 24, 2021

@vnkozlov
The hotspot label was successfully added.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 24, 2021

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Looks good!

Thanks,
David

@openjdk
Copy link

@openjdk openjdk bot commented Dec 24, 2021

@vnkozlov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8279195: Document the -XX:+NeverActAsServerClassMachine flag

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 24, 2021
@vnkozlov
Copy link
Author

@vnkozlov vnkozlov commented Dec 24, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Dec 24, 2021

Going to push as commit 2945b78.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 6588bed: 8278889: AArch64: [vectorapi] VectorMaskLoadStoreTest.testMaskCast() test fail

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Dec 24, 2021
@openjdk openjdk bot closed this Dec 24, 2021
@openjdk openjdk bot removed ready rfr labels Dec 24, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 24, 2021

@vnkozlov Pushed as commit 2945b78.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@vnkozlov vnkozlov deleted the JDK-8279195 branch Dec 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hotspot integrated
2 participants