Skip to content

fix generated client plural for SandboxUpdateOps - #27

Merged
furykerry merged 1 commit into
openkruise:masterfrom
zyl1121:codex/fix-sandboxupdateops-plural
May 20, 2026
Merged

fix generated client plural for SandboxUpdateOps#27
furykerry merged 1 commit into
openkruise:masterfrom
zyl1121:codex/fix-sandboxupdateops-plural

Conversation

@zyl1121

@zyl1121 zyl1121 commented May 19, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes #26

The SandboxUpdateOps CRD is served under the plural resource name sandboxupdateops, but the generated Go client was using sandboxupdateopses.

This broke typed client and informer operations for SandboxUpdateOps, because the apiserver only serves:

/apis/agents.kruise.io/v1alpha1/namespaces/{ns}/sandboxupdateops

Fix

Use client-gen --plural-exceptions for SandboxUpdateOps instead of manually editing generated files:

  • --plural-exceptions "SandboxUpdateOps:SandboxUpdateOps"

Then regenerate the client, informer, lister, and fake client output.

Validation

  • Verified the generated typed client now uses sandboxupdateops instead of sandboxupdateopses.
  • Verified generated informer, lister, and client API names were updated consistently.
  • Added a regression test that asserts the generated typed client sends List requests to /sandboxupdateops.

@kruise-bot

Copy link
Copy Markdown

Welcome @zyl1121! It looks like this is your first PR to openkruise/agents-api 🎉

@furykerry furykerry left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kruise-bot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: furykerry

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@furykerry
furykerry merged commit 2596a59 into openkruise:master May 20, 2026
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

generated SandboxUpdateOps client uses wrong plural resource

3 participants