fix generated client plural for SandboxUpdateOps - #27
Merged
furykerry merged 1 commit intoMay 20, 2026
Conversation
|
Welcome @zyl1121! It looks like this is your first PR to openkruise/agents-api 🎉 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: furykerry The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #26
The
SandboxUpdateOpsCRD is served under the plural resource namesandboxupdateops, but the generated Go client was usingsandboxupdateopses.This broke typed client and informer operations for
SandboxUpdateOps, because the apiserver only serves:/apis/agents.kruise.io/v1alpha1/namespaces/{ns}/sandboxupdateopsFix
Use
client-gen --plural-exceptionsforSandboxUpdateOpsinstead of manually editing generated files:--plural-exceptions "SandboxUpdateOps:SandboxUpdateOps"Then regenerate the client, informer, lister, and fake client output.
Validation
sandboxupdateopsinstead ofsandboxupdateopses.Listrequests to/sandboxupdateops.