docs: add authors, image reference, and update proposal#673
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @ZeroCoder-dot! It looks like this is your first PR to openkruise/agents 🎉 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #673 +/- ##
==========================================
- Coverage 80.34% 80.25% -0.09%
==========================================
Files 231 231
Lines 18057 18095 +38
==========================================
+ Hits 14507 14523 +16
- Misses 2963 2984 +21
- Partials 587 588 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
|
||
| ### Architecture Overview | ||
|
|
||
| ```mermaid |
There was a problem hiding this comment.
please:
The original struct should not be removed. We can provide a layered introduction: the original Mermaid diagram represents the component-level call flow and architecture, whereas the latest architecture diagram illustrates the sidecar relationships at the container runtime layer, including propagation paths and CSI mount locations.
There was a problem hiding this comment.
Pull request overview
Updates an existing design proposal document for “On-Demand CSI Volume Mount in Sandbox Runtime” by refreshing proposal metadata and adding an externally hosted architecture diagram to improve readability.
Changes:
- Added two co-authors to the proposal front-matter and metadata table.
- Updated the proposal “last-updated/Updated” dates to 2026-07-20.
- Added an architecture image (and accompanying explanatory text) to the Architecture Overview section.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| | Metadata | Details | | ||
| |----------|---------| | ||
| | **Author** | jicheng.sk <jicheng.sk@alibaba-inc.com> | | ||
| | **Author** | jicheng.sk <jicheng.sk@alibaba-inc.com>, mowangdk, ZeroCoder-dot | |
| **Component-level call flow** — the following mermaid diagram illustrates the control-plane to data-plane invocation chain and the persistence and restoration paths: | ||
|
|
||
| ```mermaid | ||
| flowchart TB |
|
|
||
| **Container runtime layer** — the diagram below zooms into the sandbox pod and illustrates the sidecar relationship, mount propagation paths, and where the CSI mount occurs: | ||
|
|
||
|  |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (2)
docs/proposals/20260608-dynamic-csi-mount.md:154
- PR description says the mermaid diagram is being replaced by an architecture image, but this section keeps the mermaid diagram and adds an image below. Please either remove the mermaid diagram (and its intro) or adjust the PR description/section wording to reflect that both diagrams are intentionally kept.
**Component-level call flow** — the following mermaid diagram illustrates the control-plane to data-plane invocation chain and the persistence and restoration paths:
```mermaid
docs/proposals/20260608-dynamic-csi-mount.md:187
- The PR notes mention using an architecture image from openkruise.io, but the markdown links to raw.githubusercontent.com pinned to a specific commit. Please confirm the intended hosting/source and update either the link (e.g., to the openkruise.io-served URL) or the PR notes to match.
| | Metadata | Details | | ||
| |----------|---------| | ||
| | **Author** | jicheng.sk <jicheng.sk@alibaba-inc.com> | | ||
| | **Author** | jicheng.sk <jicheng.sk@alibaba-inc.com>, @mowangdk, @ZeroCoder-dot | |
Signed-off-by: 张保平 <14298857+zero-xiamo@user.noreply.gitee.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
docs/proposals/20260608-dynamic-csi-mount.md:154
- PR description says the mermaid diagram was replaced with an architecture image, but the document still keeps the mermaid diagram and adds the image below. Please either (a) update the PR description to match ("add image reference"), or (b) remove/replace the mermaid diagram section here so the doc matches the stated intent.
**Component-level call flow** — the following mermaid diagram illustrates the control-plane to data-plane invocation chain and the persistence and restoration paths:
```mermaid
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. Describe how to verify it
View the proposal at docs/proposals/20260608-dynamic-csi-mount.md, confirm authors and architecture image render correctly.
Ⅳ. Special notes for reviews
Image hosted at openkruise/openkruise.io static/img/kruiseagents/on-demand-csi-mount-architecture.png