Skip to content

Bend update #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jan-warchol merged 9 commits into from
Dec 5, 2013
Merged

Bend update #16

jan-warchol merged 9 commits into from
Dec 5, 2013

Conversation

@jan-warchol
Copy link
Member

@jan-warchol jan-warchol commented Dec 1, 2013

@fedelibre please review.

@jan-warchol
Copy link
Member Author

jan-warchol commented Dec 5, 2013

@fedelibre Hi Federico,

any chances of you reviewing this pull request in the next few days or should i merge it now? I wouldn't like to leave it hanging around open.

@fedelibre
Copy link
Contributor

fedelibre commented Dec 5, 2013

Ok, please merge it.
I haven't used it since more than a year maybe, so I'll test it during christmas holidays and I hope to document it. How can I do it?

For example, I remember a limitation: you cannot typeset a bend release followed by a pull-off, because you can't start a slur while \bendOn is still active. That's one of the reasons why a specific engraver would be better.

@jan-warchol
Copy link
Member Author

jan-warchol commented Dec 5, 2013

In case of general problems and limitations (like the one you mention), please write them in a README.md file inside snippet's directory. If you're unsure, just make a pull request and i'll review it.

Should i expect a new pull request with LilyJAZZ soon? ;-)

Thanks!

jan-warchol and others added 9 commits December 5, 2013 23:13
@jan-warchol
bend: add snippet information
26d3b7b
@jan-warchol
bend: remove old, unused code
6131f8e 
Apparently there were 3 attempts to get the pointed-slur function
right, and the last one was chosen.  Previous attempts seem to be
unused.
@jan-warchol
bend: some cleanup
7390abd
@jan-warchol
bend: override slur in appropriate place
336f7cf
@jan-warchol
bend: change variable names, remove spurious comments
40f7ebe
@jan-warchol
bend: don't list Thomas as author (according to his wish)
cc1e305
@jan-warchol
bend: prevent grace notes from being erroneously beamed
3738fbc 
The beaming problem appeared in version 2.17.28,
when automatic grace note beaming was added.
@jan-warchol
bend: change define-public to define
0d1964f 
define-public seems to make no sense here.
@fedelibre @jan-warchol
bend: add description
1abb7be
@jan-warchol jan-warchol merged commit 1abb7be into master Dec 5, 2013
@jan-warchol jan-warchol deleted the bend-update branch December 5, 2013 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jan-warchol @fedelibre