Skip to content

Adding support for Fedora 38#113

Merged
pleia2 merged 2 commits intoopenmainframeproject:masterfrom
xtanion:fedora38
May 16, 2023
Merged

Adding support for Fedora 38#113
pleia2 merged 2 commits intoopenmainframeproject:masterfrom
xtanion:fedora38

Conversation

@xtanion
Copy link
Copy Markdown
Contributor

@xtanion xtanion commented May 14, 2023

Fixes #109

@arshPratap
Copy link
Copy Markdown
Member

@xtanion please mention the issue you are trying to fix in the PR.. This makes it easier for us to keep a track for the said issues.. Anyways seems to be an authentication issue with your mail account and github account

@xtanion
Copy link
Copy Markdown
Contributor Author

xtanion commented May 14, 2023

Hi @arshPratap. I updated the description, PTAL.
Thanks.

@pleia2
Copy link
Copy Markdown
Contributor

pleia2 commented May 15, 2023

Thanks for your work on this! The DCO check is a requirement for all Open Mainframe Project projects, here's how to fix the test: https://github.com/openmainframeproject/software-discovery-tool/pull/113/checks?check_run_id=13464508729

In the future, you can use the following on the command line when doing your commit to avoid this: git commit -a --signoff

xtanion added 2 commits May 16, 2023 12:00
Signed-off-by: xtanion <anandshivam54321@gmail.com>
Signed-off-by: xtanion <anandshivam54321@gmail.com>
@xtanion
Copy link
Copy Markdown
Contributor Author

xtanion commented May 16, 2023

Done @pleia2, PTAL
Thanks

@pleia2 pleia2 merged commit 1cc8acc into openmainframeproject:master May 16, 2023
TusharB-07 pushed a commit to TusharB-07/software-discovery-tool that referenced this pull request Apr 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support to package_build.py for Fedora 38

3 participants