Allow mesh material volume calculations outside model geometry#4028
Open
paulromano wants to merge 6 commits into
Open
Allow mesh material volume calculations outside model geometry#4028paulromano wants to merge 6 commits into
paulromano wants to merge 6 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates
Mesh.material_volumesto support meshes that extend beyond the model geometry. During ray tracing, regions outside the geometry are simply treated as void material. This enables a user to, for example, use Cartesian meshes to cover geometries with a curved outside boundary (sphere, cylinder). The implementation follows the ray-traced plotting approach for locating model boundaries from undefined space (utilizingadvance_to_boundary_from_void). Tests have been updated, including a comparison against an equivalent geometry with an explicit enclosing void cell.Checklist