Skip to content

Allow mesh material volume calculations outside model geometry#4028

Open
paulromano wants to merge 6 commits into
openmc-dev:developfrom
paulromano:mmv-outside-geometry
Open

Allow mesh material volume calculations outside model geometry#4028
paulromano wants to merge 6 commits into
openmc-dev:developfrom
paulromano:mmv-outside-geometry

Conversation

@paulromano

Copy link
Copy Markdown
Contributor

Description

Updates Mesh.material_volumes to support meshes that extend beyond the model geometry. During ray tracing, regions outside the geometry are simply treated as void material. This enables a user to, for example, use Cartesian meshes to cover geometries with a curved outside boundary (sphere, cylinder). The implementation follows the ray-traced plotting approach for locating model boundaries from undefined space (utilizing advance_to_boundary_from_void). Tests have been updated, including a comparison against an equivalent geometry with an explicit enclosing void cell.

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format (version 18) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant