Resolve relative input paths relative to XML files - #4031
Merged
Conversation
GuySten
approved these changes
Jul 27, 2026
GuySten
left a comment
Contributor
There was a problem hiding this comment.
I've updated plots.py.
Looks good to me now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, if you call
Model.from_model_xml()on a model.xml file that is not in your current directory, any files that it references with a relative path will be treated as though they are relative to your current working directory rather than the parent directory of the XML file itself. This PR fixes this so that XML-loading entry points now establish the directory containing the source XML file as the path-resolution context. Nested inputs such as DAGMC geometry, meshes, and other referenced files are therefore found relative to the XML file rather than the process's current working directory whenopenmc.config['resolve_paths']is enabled. The context is scoped and safely restored after parsing, including nested XML-loading operations.Checklist
I have run clang-format (version 18) on any C++ source files (if applicable)