fix: fix paddings issues & align delete button for visited cards#155
fix: fix paddings issues & align delete button for visited cards#155Sobyt483 wants to merge 2 commits into
Conversation
Signed-off-by: Sobyt483 <andrianingomel@gmail.com>
|
Warning Review limit reached
More reviews will be available in 49 minutes and 49 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR refines dashboard and card component styling by introducing theme-driven CSS variables for padding across multiple layers, adding responsive media queries for viewport-specific spacing, adjusting visited card positioning, and synchronizing card heights in storybook configurations. ChangesLayout and Spacing Refinements
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@projects/ngx/declarative-ui/dashboard/dashboard/dashboard.component.scss`:
- Around line 91-94: The padding in the .mfp-dashboard rule uses a typo'd calc
value (calc(1023px - 10px)); update the mobile breakpoint to use the intended
small spacing variable by replacing calc(1023px - 10px) with calc(1rem - 10px)
so --sapShell_Space_S reflects 1rem; locate the .mfp-dashboard rule in
projects/ngx/declarative-ui/dashboard/dashboard/dashboard.component.scss and
adjust the padding expression accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 917b261e-810b-420d-ae10-0b8d92f94652
📒 Files selected for processing (8)
projects/ngx/cards/visited-service-card/visited-service-card.component.scssprojects/ngx/declarative-ui/dashboard/card/dashboard-card.component.scssprojects/ngx/declarative-ui/dashboard/dashboard/dashboard.component.htmlprojects/ngx/declarative-ui/dashboard/dashboard/dashboard.component.scssprojects/ngx/declarative-ui/dashboard/dashboard/dashboard.component.tsprojects/ngx/declarative-ui/dashboard/section/dashboard-section.component.scssprojects/ngx/declarative-ui/stories/dashboard.cards.tsprojects/ngx/declarative-ui/stories/dashboard.stories.ts
Signed-off-by: Sobyt483 <andrianingomel@gmail.com>
Summary by CodeRabbit
Style
Layout