Skip to content

fix: fix paddings issues & align delete button for visited cards #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sobyt483 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: fix paddings issues & align delete button for visited cards #155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d8014f
fix: fix paddings issues & align delete button for visited cards
Sobyt483 May 27, 2026
39b9540
fix: fix typo
Sobyt483 May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions projects/ngx/cards/visited-service-card/visited-service-card.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

.visited-card-wrapper {
position: relative;
padding-top: 0.625rem;
cursor: pointer;
}

Expand All @@ -14,7 +13,7 @@

.visited-card__type-badge {
position: absolute;
top: 0;
top: -0.625rem;
right: 0.75rem;
display: inline-block;
padding: 0.125rem 0.625rem;
Expand Down
3 changes: 2 additions & 1 deletion projects/ngx/declarative-ui/dashboard/card/dashboard-card.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@
height: 100%;
overflow: visible;
isolation: isolate;
padding: 0 0.5rem;
padding-inline-start: var(--mfp_cardContainerPadding, 10px);
padding-inline-end: var(--mfp_cardContainerPadding, 10px);
}

.component-host {
Expand Down
2 changes: 1 addition & 1 deletion projects/ngx/declarative-ui/dashboard/dashboard/dashboard.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@
/>
}
</div>
<gridstack #grid [options]="gridOptions()" (removedCB)="onGridChange($event)" (addedCB)="onGridChange($event)" (changeCB)="onGridChange($event)">
<gridstack #grid [options]="gridOptions()" (addedCB)="onGridChange($event)" (changeCB)="onGridChange($event)" (removedCB)="onGridChange($event)">
@for (card of looseCards(); track card.id) {
<gridstack-item
[options]="card"
Expand Down
21 changes: 20 additions & 1 deletion projects/ngx/declarative-ui/dashboard/dashboard/dashboard.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ mfp-wc-dashboard {
}

.mfp-dashboard {
padding: 2rem;
padding: calc(var(--sapShell_Space_XL, 3rem) - 10px);
}

.mfp-sections-container {
Expand Down Expand Up @@ -49,6 +49,7 @@ mfp-wc-dashboard {
align-items: flex-start;
justify-content: space-between;
gap: 1rem;
padding: 0px 10px;
}

.mfp-dashboard__header {
Expand Down Expand Up @@ -86,3 +87,21 @@ mfp-wc-dashboard {
box-sizing: border-box;
overflow: hidden;
}

@media screen and (min-width: 0px) and (max-width: 599px) {
.mfp-dashboard {
padding: calc(var(--sapShell_Space_S, 1rem) - 10px);
}
Comment thread
coderabbitai[bot] marked this conversation as resolved.
}

@media screen and (min-width: 600px) and (max-width: 1023px) {
.mfp-dashboard {
padding: calc(var(--sapShell_Space_M, 2rem) - 10px);
}
}

@media screen and (min-width: 1024px) and (max-width: 1439px) {
.mfp-dashboard {
padding: calc(var(--sapShell_Space_L, 2rem) - 10px);
}
}
3 changes: 3 additions & 0 deletions projects/ngx/declarative-ui/dashboard/dashboard/dashboard.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,9 @@ export class Dashboard implements OnInit, OnDestroy {
cellHeight: CELL_HEIGHT,
disableResize: !this.editMode(),
disableDrag: !this.editMode(),
marginBottom: 0,
marginLeft: 0,
marginRight: 0,
columnOpts: {
breakpointForWindow: true,
breakpoints: [
Expand Down
5 changes: 3 additions & 2 deletions projects/ngx/declarative-ui/dashboard/section/dashboard-section.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
border: 1px solid transparent;
border-top: none;
border-radius: 0 0 0.5rem 0.5rem;
padding: 1.25rem 0.75rem 0.75rem;
padding-top: 1.25rem;

&--edit {
border-color: var(--sapGroup_ContentBorderColor, #d9d9d9);
Expand Down Expand Up @@ -73,7 +73,8 @@
display: grid;
grid-template-columns: repeat(var(--cols, 12), 1fr);
grid-auto-rows: var(--row-height, 10px);
gap: var(--row-gap, 0px);
column-gap: var(--column-gap, 0px);
row-gap: var(--row-gap, 0px);

@media (max-width: 599px) {
grid-template-columns: 1fr;
Expand Down
8 changes: 4 additions & 4 deletions projects/ngx/declarative-ui/stories/dashboard.cards.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ export const CARDS: CardConfig[] = [
{
id: 'table-pods',
w: 12,
h: 37,
h: 35,
component: 'mfp-wc-declarative-table-card',
componentInputs: {
config: TABLE_CARD_CONFIG,
Expand All @@ -89,15 +89,15 @@ export const CARDS: CardConfig[] = [
label: "What's New",
type: 'angular',
w: 6,
h: 57,
h: 55,
component: 'mfp-whats-new',
},
{
id: 'favorites',
label: 'Favorites',
type: 'angular',
w: 6,
h: 21,
h: 20,
minW: 3,
maxW: 6,
minH: 10,
Expand All @@ -109,7 +109,7 @@ export const CARDS: CardConfig[] = [
label: 'Service Status',
type: 'angular',
w: 6,
h: 30,
h: 28,
component: 'mfp-service-status-card',
},
];
8 changes: 4 additions & 4 deletions projects/ngx/declarative-ui/stories/dashboard.stories.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ const AVAILABLE_CARDS: CardConfig[] = [
id: 'table-pods',
label: 'Pods Table',
w: 12,
h: 37,
h: 35,
component: 'mfp-wc-declarative-table-card',
componentInputs: {
config: TABLE_CARD_CONFIG,
Expand All @@ -63,23 +63,23 @@ const AVAILABLE_CARDS: CardConfig[] = [
label: "What's New",
type: 'angular',
w: 6,
h: 57,
h: 55,
component: 'mfp-whats-new',
},
{
id: 'favorites',
label: 'Favorites',
type: 'angular',
w: 6,
h: 21,
h: 20,
component: 'mfp-favorites',
},
{
id: 'service-status',
label: 'Service Status',
type: 'angular',
w: 6,
h: 30,
h: 28,
component: 'mfp-service-status-card',
},
];
Expand Down