Skip to content

Conversation

@JATAYU000
Copy link
Contributor

@JATAYU000 JATAYU000 commented Dec 30, 2025

The CI runs only on python versions 3.8 and 3.9 both of which have already reached end of life.

This PR updates the python versions, deprecating any logic that runs tests on python versions 3.8 and 3.9, or scikit-learn versions of that age.

Metadata

Reference Issue: #1544

Depends on #1584 fofr a fix, which should be merged first.

Details

@fkiraly fkiraly changed the title [BUG] Marking remaining failed tests as expected fail. [MNT] extend CI to newer python versions, deprecate python versions 3.8, 3.9 after EOL, marking further failing tests as xfail Dec 30, 2025
@fkiraly fkiraly added the maintenance & CI Continuous integration & package distribution label Dec 30, 2025
@fkiraly
Copy link
Collaborator

fkiraly commented Dec 30, 2025

FYI @JATAYU000, I have merged #1571 into this for simplicity.

This also allows us to track down any further failing tests.

@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.70%. Comparing base (3380bbb) to head (b1e06ec).
⚠️ Report is 165 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (3380bbb) and HEAD (b1e06ec). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (3380bbb) HEAD (b1e06ec)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1579       +/-   ##
===========================================
- Coverage   85.24%   52.70%   -32.54%     
===========================================
  Files          38       36        -2     
  Lines        5008     4320      -688     
===========================================
- Hits         4269     2277     -1992     
- Misses        739     2043     +1304     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still a few failing tests, and also fixture construction errors - could you look at those too, @JATAYU000?

@JATAYU000
Copy link
Contributor Author

There are still a few failing tests, and also fixture construction errors - could you look at those too, @JATAYU000?

Yes will look into it

@JATAYU000
Copy link
Contributor Author

@fkiraly #1584 needs to be merged first for fixing

AsertionError
assert False
 +  where False = exists()

Would like your inputs on this fix

@fkiraly
Copy link
Collaborator

fkiraly commented Dec 31, 2025

ok, I will also check whether that resolves the failures here.

@fkiraly
Copy link
Collaborator

fkiraly commented Dec 31, 2025

this fixed the issue, so you should remove the xfails from the fixed tests (see CI runs)

Not in this PR, but in #1584, and I will merge the changes to here as well for more extensive testing.

fkiraly pushed a commit that referenced this pull request Dec 31, 2025
#### Metadata
* Reference Issue: Refer failures in #1579 
* New Tests Added: No
* Documentation Updated: No
* Change Log Entry: Checks if the directory was created newly else doesn't remove.


### Details
* What does this PR implement/fix? Explain your changes.
`get_task` checks if the `tid_cache_dir` was already existing before removing it on `Exception`
* Why is this change necessary? What is the problem it solves?
`OpenMLServerException` causes `get_task` to remove the entire directory even if the directory was already existing and is used by other tests
* How can I reproduce the issue this PR is solving and its solution?
observe `exists assertion` errors for files under `tests/files/org/openml/test/task/1/` after running `pytest` 
or look at failures in #1579
@JATAYU000
Copy link
Contributor Author

@fkiraly I am a bit lost on whats happening here, How are the all 48 tests (marked as xfail) passing under sk-only:False ?, #1584 only fixes a few of those

@fkiraly
Copy link
Collaborator

fkiraly commented Dec 31, 2025

A PR by @PGijsbers got merged which seems to fix these.
#1585

Unfortunately, this was unexpected since I thought he was on holiday until Jan - but it seems to be a fix, so we should adapt this PR to the new repository state.

I would suggest to revert the tests that are now fixed, could you quickly do that?

@JATAYU000
Copy link
Contributor Author

I would suggest to revert the tests that are now fixed, could you quickly do that?

Sure, Thank you

@fkiraly
Copy link
Collaborator

fkiraly commented Dec 31, 2025

@JATAYU000, you still need to deal with the sk-only: False tests

@JATAYU000
Copy link
Contributor Author

@JATAYU000, you still need to deal with the sk-only: False tests

Yes those tests marks are removed, rest are passing till now the check is still in progress

@JATAYU000
Copy link
Contributor Author

JATAYU000 commented Dec 31, 2025

@JATAYU000, you still need to deal with the sk-only: False tests

@fkiraly Can you point me which tests under sk-only: False are not handled yet? because I have updated all of them as far as I know reference workflow fail.

@JATAYU000 JATAYU000 requested a review from fkiraly December 31, 2025 12:47
Copy link
Collaborator

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we have the failing tests under control now.

@fkiraly fkiraly merged commit bd8ae77 into openml:main Dec 31, 2025
48 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance & CI Continuous integration & package distribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants