Conversation
Codecov Report
@@ Coverage Diff @@
## develop #255 +/- ##
===========================================
+ Coverage 89.69% 90.45% +0.75%
===========================================
Files 24 24
Lines 2058 2064 +6
===========================================
+ Hits 1846 1867 +21
+ Misses 212 197 -15
Continue to review full report at Codecov.
|
mfeurer
requested changes
May 15, 2017
| "criterion": ["gini", "entropy"]}, | ||
| num_iterations, random_state=42) | ||
|
|
||
| # [SPEED] make unit test faster by exploiting run information from the past |
Collaborator
There was a problem hiding this comment.
Maybe it would be easier to only test _create_trace_from_description and hope that the additional line get_run_trace works.
Member
Author
There was a problem hiding this comment.
Not so sure. This is the one thing this function is supposed to test. Let's keep it for now?
| self.assertEqual(len(run_trace.trace_iterations), num_iterations * num_folds) | ||
|
|
||
| def test__run_exists(self): | ||
| # would be better to not sentinel these clfs .. |
| check_res = self._check_serialized_optimized_run(run.run_id) | ||
| self.assertTrue(check_res) | ||
|
|
||
| # todo: check if runtime is present |
Collaborator
There was a problem hiding this comment.
Maybe you should add this check ;)
mfeurer
approved these changes
May 15, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extended unit tests,
fixed some bugs that came up