Skip to content

MAINT update license information#367

Merged
joaquinvanschoren merged 1 commit intodevelopfrom
update_license_information
Oct 20, 2017
Merged

MAINT update license information#367
joaquinvanschoren merged 1 commit intodevelopfrom
update_license_information

Conversation

@mfeurer
Copy link
Copy Markdown
Collaborator

@mfeurer mfeurer commented Oct 16, 2017

No description provided.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 16, 2017

Codecov Report

Merging #367 into develop will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #367      +/-   ##
===========================================
+ Coverage     89.8%   89.84%   +0.03%     
===========================================
  Files           32       32              
  Lines         2571     2571              
===========================================
+ Hits          2309     2310       +1     
+ Misses         262      261       -1
Impacted Files Coverage Δ
openml/tasks/functions.py 86.79% <0%> (+0.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50ffc21...c13c7b0. Read the comment docs.

@amueller
Copy link
Copy Markdown
Contributor

I am 100% in favor. In theory, you need to check this with any author of any code in the project. Given that the project is still relatively small, I think you should probably try.

Copy link
Copy Markdown
Contributor

@amueller amueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving to not block the merge, but I suggest reaching out to the other authors. I'm fine with this, obviously. And I think you only need approval of authors that still have code in here.

@amueller
Copy link
Copy Markdown
Contributor

Here are authors that still have lines in the code:

> for FILE in $(git ls-files) ; do git blame $FILE --porcelain | grep "^author " ; done | sort | uniq

author Anatolii Domashnev
author Andreas Mueller
author Jan van Rijn
author Jesper van Engelen
author Joaquin Vanschoren
author Matthias Feurer
author Minori Inoue
author Pieter Gijsbers
author Randy Olson
author toon
author Zardaloop

(slightly cleaned)

@joaquinvanschoren
Copy link
Copy Markdown
Contributor

@adomashnev @janvanrijn @engelen @mfeurer @minoriinoue @PG-TUe @rhiever @toontesting @zardaloop: we decided a while ago to license all OpenML code under BSD (3-clause).
Since the code includes some code of you, we wanted to double-check if you are ok with this.
Please raise any objections by tomorrow.

@PGijsbers
Copy link
Copy Markdown
Collaborator

Not a problem for me.

@mfeurer mfeurer requested a review from janvanrijn October 19, 2017 14:51
@joaquinvanschoren
Copy link
Copy Markdown
Contributor

No objections :)

@joaquinvanschoren joaquinvanschoren merged commit 4d32758 into develop Oct 20, 2017
@joaquinvanschoren joaquinvanschoren deleted the update_license_information branch October 20, 2017 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants