Skip to content

Improve error logging#372

Merged
janvanrijn merged 3 commits intodevelopfrom
improve_error_logging
Nov 29, 2017
Merged

Improve error logging#372
janvanrijn merged 3 commits intodevelopfrom
improve_error_logging

Conversation

@mfeurer
Copy link
Copy Markdown
Collaborator

@mfeurer mfeurer commented Nov 2, 2017

This branch makes tracking errors easier. It

  • adds the url to the OpenMLServerException to actually know which call failed
  • makes sure the whole dataset arff is downloaded by checking the md5hash

@mfeurer mfeurer requested a review from janvanrijn November 29, 2017 08:53
@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 29, 2017

Codecov Report

Merging #372 into develop will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #372      +/-   ##
==========================================
+ Coverage    89.56%   89.6%   +0.04%     
==========================================
  Files           32      32              
  Lines         2577    2587      +10     
==========================================
+ Hits          2308    2318      +10     
  Misses         269     269
Impacted Files Coverage Δ
openml/exceptions.py 100% <100%> (ø) ⬆️
openml/_api_calls.py 88.88% <100%> (ø) ⬆️
openml/datasets/functions.py 90.56% <100%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32e98a6...200b56c. Read the comment docs.

@janvanrijn janvanrijn merged commit 4d5d118 into develop Nov 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants