Modularizes the _run_task_get_arffcontent function#379
Merged
janvanrijn merged 16 commits intodevelopfrom Nov 29, 2017
Merged
Conversation
…he internal models could potentially be accessed by the outside world.
Codecov Report
@@ Coverage Diff @@
## develop #379 +/- ##
===========================================
- Coverage 89.6% 89.34% -0.26%
===========================================
Files 32 32
Lines 2587 2610 +23
===========================================
+ Hits 2318 2332 +14
- Misses 269 278 +9
Continue to review full report at Codecov.
|
mfeurer
approved these changes
Nov 29, 2017
| for file_dict in run['oml:output_data']['oml:file']: | ||
| output_data = run['oml:output_data'] | ||
| if 'oml:file' in output_data: | ||
| if isinstance(output_data['oml:file'], dict): |
Collaborator
There was a problem hiding this comment.
You could use the force_list argument to the xml parsing here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
so we can access individual models of folds, and manipulate them