Skip to content

fix for list_all. It currently keeps looping forever (until the conne… #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mfeurer merged 3 commits into from
Feb 20, 2018
Merged

fix for list_all. It currently keeps looping forever (until the conne… #390

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4065167
fix for list_all. It currently keeps looping forever (until the conne…
joaquinvanschoren Feb 1, 2018
3aafe72
Merge branch 'develop' into joaquinvanschoren-patch-1
janvanrijn Feb 19, 2018
bc07b9c
Merge branch 'develop' into joaquinvanschoren-patch-1
mfeurer Feb 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion openml/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,9 +118,10 @@ def list_all(listing_call, batch_size=10000, *args, **filters):
dict
"""
page = 0
has_more = 1
result = {}

while True:
while has_more:
try:
new_batch = listing_call(
*args,
Expand All @@ -135,5 +136,6 @@ def list_all(listing_call, batch_size=10000, *args, **filters):
break
result.update(new_batch)
page += 1
has_more = (len(new_batch) == batch_size)

return result