Conversation
bugfix syntax and list indexing
|
@mfeurer Could you have a look this week? Thanks! |
Codecov Report
@@ Coverage Diff @@
## develop #394 +/- ##
===========================================
- Coverage 89.34% 89.18% -0.17%
===========================================
Files 32 32
Lines 2610 2653 +43
===========================================
+ Hits 2332 2366 +34
- Misses 278 287 +9
Continue to review full report at Codecov.
|
mfeurer
left a comment
mfeurer
left a comment
There was a problem hiding this comment.
I don't get what you mean with Localruns, could you please explain that?
|
|
||
|
|
||
| def _tag_entity(entity_type, entity_id, tag, untag=False): | ||
| """Abstract function that can be used as a partial for tagging entities |
There was a problem hiding this comment.
I do not see where this is used as a partial (assuming you mean functools.partial). Could you please clarify the docstring?
There was a problem hiding this comment.
I haven't put these functions in yet. I will change the description, as this function can also be used standalone.
|
|
||
| def test_get_cached_setup(self): | ||
| openml.config.set_cache_directory(self.static_cache_dir) | ||
| openml.setups.functions._get_cached_setup(1) |
There was a problem hiding this comment.
It would be great to have a test which checks that there's an exception for trying to access an uncached dataset.
There was a problem hiding this comment.
Don't see how this would be different from test_get_uncached_setup() ?
We now test the following cases:
- test_get_setup (downloads a setup and caches it)
- test_get_cached_setup (retrieves a setup from cache)
- test_get_uncached_setup (tries to retrieve an uncached setup, and throws an error)
| Returns | ||
| ------- | ||
| tags : list | ||
| List of tags that the entity is still tagged with |
There was a problem hiding this comment.
Maybe write List of tags that the entity is (still) tagged with because the number of tags could also increase, right?
|
Localruns: a run object that is stored locally before uploading (hence it does not contain run id, uploader, upload_date, etc) |
3 participants
This PR contains three branches: