Skip to content

Fix check_datasets_active and corresponding unit test#642

Merged
mfeurer merged 7 commits intodevelopfrom
fix149
Mar 18, 2019
Merged

Fix check_datasets_active and corresponding unit test#642
mfeurer merged 7 commits intodevelopfrom
fix149

Conversation

@PGijsbers
Copy link
Copy Markdown
Collaborator

This solves an issue hinted at in #149. While retrieving deactivated datasets worked perfectly well, the check_datasets_active method was seemingly not updated for some latest changes, and its unit test was outdated too (it was disabled).

This PR:

  • Fixes a bug in check_datasets_active where deactivated datasets would never be found due to not specifying status='all' in the list_datasets call (presumably because the default behavior was changed at some point).
  • Correctly points the unit test to the production server, as there is no deactivated dataset on the test server.
  • Updated the dataset id that is supposed to refer to an active dataset from 1 to 2 in the unit test (since d/1 is now deactivated).
  • reactivates the fixed unit test
  • refactored the flow of check_datasets_active a little for legibility and to avoid "excessive" looping/evaluations (minor but still nice :) )

… production server as test server does not have deactivated datasets.
…ed). Fix retrieving all datasets instead of only active ones. Add documentation.
@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 17, 2019

Codecov Report

Merging #642 into develop will decrease coverage by 0.21%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #642      +/-   ##
===========================================
- Coverage    90.64%   90.43%   -0.22%     
===========================================
  Files           32       32              
  Lines         3390     3365      -25     
===========================================
- Hits          3073     3043      -30     
- Misses         317      322       +5
Impacted Files Coverage Δ
openml/datasets/functions.py 96.18% <100%> (+4.13%) ⬆️
openml/datasets/dataset.py 82.4% <0%> (-6.01%) ⬇️
openml/utils.py 91.5% <0%> (-0.56%) ⬇️
openml/runs/functions.py 86.65% <0%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aecb6ac...50ce5e0. Read the comment docs.

@PGijsbers
Copy link
Copy Markdown
Collaborator Author

Appveyor fails unrelated to this code change, see #643.

@PGijsbers PGijsbers requested a review from mfeurer March 17, 2019 13:38
@PGijsbers
Copy link
Copy Markdown
Collaborator Author

Issue with AppVeyor is fixed in #645.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants