Conversation
… production server as test server does not have deactivated datasets.
…ed). Fix retrieving all datasets instead of only active ones. Add documentation.
…checks on datasets that were not asked for.
Codecov Report
@@ Coverage Diff @@
## develop #642 +/- ##
===========================================
- Coverage 90.64% 90.43% -0.22%
===========================================
Files 32 32
Lines 3390 3365 -25
===========================================
- Hits 3073 3043 -30
- Misses 317 322 +5
Continue to review full report at Codecov.
|
Collaborator
Author
|
Appveyor fails unrelated to this code change, see #643. |
Collaborator
Author
|
Issue with AppVeyor is fixed in #645. |
mfeurer
approved these changes
Mar 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solves an issue hinted at in #149. While retrieving deactivated datasets worked perfectly well, the
check_datasets_activemethod was seemingly not updated for some latest changes, and its unit test was outdated too (it was disabled).This PR:
check_datasets_activewhere deactivated datasets would never be found due to not specifyingstatus='all'in thelist_datasetscall (presumably because the default behavior was changed at some point).check_datasets_activea little for legibility and to avoid "excessive" looping/evaluations (minor but still nice :) )