add tag_entity as backend#667
add tag_entity as backend#667mfeurer merged 6 commits intoopenml:developfrom sahithyaravi:fix619_tagfunctions
Conversation
|
Thanks a lot for your contribution @sahithyaravi1493, this looks like a useful improvement. However, the static style checker in the continuous integration system complains about an unused import. Could you please check that? Should fix #619. |
Codecov Report
@@ Coverage Diff @@
## develop #667 +/- ##
===========================================
+ Coverage 90.84% 90.85% +<.01%
===========================================
Files 36 36
Lines 3539 3531 -8
===========================================
- Hits 3215 3208 -7
+ Misses 324 323 -1
Continue to review full report at Codecov.
|
|
Sorry, but there's still an unused import. You can perform this check locally be running |
No problem, I will run this locally and commit. |
Ignore my recent commits, there seem to be some more errors. I could not get flake8 locally to work due to some issues. So I fixed the errors thrown by pyflakes and pep8. However, there seem to be additional errors thrown here. Will check on this. |
|
The new errors appear to be errors raised by mypy. Would it help you if the output of the two checkers would be separated? |
Hi Matthias, Yes it would help. I am unable to run flake8 locally, due to an error caused by a space in my user folder. It seemed to be a bit tricky to rename the user folder. So, I tried to run pyflakes and fix the warnings, assuming it would fix the import errors, but those fixes now resulted in mypy errors. |
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
mfeurer
left a comment
There was a problem hiding this comment.
This looks good, thanks a lot!
What does this PR implement/fix? Explain your changes.
modified
push_tagandremove_tagfunctions to calltag_entityHow should this PR be tested?
Any other comments?