Conversation
…where mentioned in docs..
…hed from the front page as 'advanced' installation.
Codecov Report
@@ Coverage Diff @@
## develop #675 +/- ##
===========================================
+ Coverage 90.85% 90.87% +0.01%
===========================================
Files 36 36
Lines 3533 3749 +216
===========================================
+ Hits 3210 3407 +197
- Misses 323 342 +19
Continue to review full report at Codecov.
|
mfeurer
reviewed
Apr 16, 2019
mfeurer
approved these changes
Apr 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
oslo.concurrency,nbformatandpytestfrom general package dependencies, as they are only used for testing (and are this under theextra_requires 'test'flag).I also updated the documentation (as I was looking for when any
python setup.py installwas mentioned). Have to hold out to see if it still works in CI setting.Locally runs as expected (downloads task, data, flow, run):
This moves the package dependencies (without test environment) from:
Successfully installed Babel-2.6.0 PyYAML-5.1 atomicwrites-1.3.0 attrs-19.1.0 certifi-2019.3.9 chardet-3.0.4 debtcollector-1.21.0 decorator-4.4.0 fasteners-0.14.1 idna-2.8 ipython-genutils-0.2.0 iso8601-0.1.12 jsonschema-3.0.1 jupyter-core-4.4.0 liac-arff-2.4.0 monotonic-1.5 more-itertools-7.0.0 nbformat-4.4.0 netaddr-0.7.19 netifaces-0.10.9 numpy-1.16.2 openml oslo.concurrency-3.29.1 oslo.config-6.8.1 oslo.i18n-3.23.1 oslo.utils-3.40.3 pandas-0.24.2 pathlib2-2.3.3 pbr-5.1.3 pluggy-0.9.0 py-1.8.0 pyparsing-2.4.0 pyrsistent-0.14.11 pytest-4.4.1 python-dateutil-2.8.0 pytz-2019.1 requests-2.21.0 rfc3986-1.2.0 scikit-learn-0.20.3 scipy-1.2.1 six-1.12.0 stevedore-1.30.1 traitlets-4.3.2 urllib3-1.24.1 wrapt-1.11.1 xmltodict-0.12.0to
Successfully installed certifi-2019.3.9 chardet-3.0.4 idna-2.8 liac-arff-2.4.0 numpy-1.16.2 openml pandas-0.24.2 python-dateutil-2.8.0 pytz-2019.1 requests-2.21.0 scikit-learn-0.20.3 scipy-1.2.1 six-1.12.0 urllib3-1.24.1 xmltodict-0.12.0:)