Obs test with groupMembers during Encounter creation.#263
Closed
dkayiwa wants to merge 2 commits intoopenmrs:masterfrom
Closed
Obs test with groupMembers during Encounter creation.#263dkayiwa wants to merge 2 commits intoopenmrs:masterfrom
dkayiwa wants to merge 2 commits intoopenmrs:masterfrom
Conversation
|
@dkayiwa, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rkorytkowski, @tmarzeion and @teleivo to be potential reviewers. |
tmarzeion
requested changes
Jan 17, 2017
| List<SimpleObject> child1GroupMembers = new ArrayList<SimpleObject>(); | ||
|
|
||
| SimpleObject child1child1 = new SimpleObject(); | ||
| child1child1.put("value", 1); |
Contributor
There was a problem hiding this comment.
These concept UUIDs needs to refer to test concept UUIDs, for example numeric one like this: c607c80f-1ea9-4da3-bb88-6276ce8868dd. Otherwise REST would not know where should it assign this numeric value (NullPointerException in this case).
| parentGroupMembers.add(child3); | ||
|
|
||
| SimpleObject parent = new SimpleObject(); | ||
| parent.put("groupMembers", parentGroupMembers); |
Contributor
There was a problem hiding this comment.
I think this concept can be removed from parent (same as for child1)
tmarzeion
reviewed
Jan 17, 2017
|
|
||
| SimpleObject child1 = new SimpleObject(); | ||
| child1child2.put("groupMembers", child1GroupMembers); | ||
| child1child2.put("concept", "c607c80f-1ea9-4da3-bb88-6276ce8868ee"); |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.