RESTWS-711- Change to new MappingJackson2HttpMessageConverter in spring 4.3.x#335
Merged
dkayiwa merged 2 commits intoopenmrs:masterfrom Feb 26, 2020
Merged
RESTWS-711- Change to new MappingJackson2HttpMessageConverter in spring 4.3.x#335dkayiwa merged 2 commits intoopenmrs:masterfrom
dkayiwa merged 2 commits intoopenmrs:masterfrom
Conversation
6 tasks
djazayeri
requested changes
Aug 25, 2018
| import org.springframework.context.annotation.Configuration; | ||
| import org.springframework.http.converter.HttpMessageConverter; | ||
|
|
||
| @Configuration |
Member
There was a problem hiding this comment.
Need some javadoc explaining what's going on here.
Member
Author
There was a problem hiding this comment.
Will do, actually I need to rename this class
|
|
||
| private static final String PACKAGE = "org.springframework.http.converter.json."; | ||
|
|
||
| private static final String OLD_CLASS_NAME = PACKAGE + "MappingJacksonHttpMessageConverter"; |
Member
There was a problem hiding this comment.
Instead of OLD_CLASS_NAME and NEW_CLASS_NAME wouldn't it be better to call these CLASS_FROM_SPRING43 and CLASS_BEFORE_SPRING43 or something?
wluyima
commented
Aug 28, 2018
|
|
||
| private static final String PACKAGE = "org.springframework.http.converter.json."; | ||
|
|
||
| private static final String CLASS_BEFORE_SPRING_4_1 = PACKAGE + "MappingJacksonHttpMessageConverter"; |
Member
Author
There was a problem hiding this comment.
Actually it's more like the OpenMRS version rather than the spring version. When we upgraded to spring 4.1.x, the dev copied the removed classes into core because I guess we were still running Jackson 1.x yet the new converter requires Jackson 2.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.openmrs.org/browse/RESTWS-711