RESTWS-813: Compared strings using .equals instead of == and !=

[insookwa]

Description of what I changed

Issue I worked on

see https://issues.openmrs.org/browse/RESTWS-813

Checklist: I completed these to help reviewers :)

• [ x] My pull request only contains ONE single commit
  (the number above, next to the 'Commits' tab is 1).

  No? -> read here on how to squash multiple commits into one

• [x ] My IDE is configured to follow the code style of this project.

  No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

• I have added tests to cover my changes. (If you refactored
  existing code that was well tested you do not have to add tests)

  No? -> write tests and add them to this commit git add . && git commit --amend

• [ x] I ran mvn clean package right before creating this pull request and
  added all formatting changes to my commit.

  No? -> execute above command

• [x ] All new and existing tests passed.

  No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

• [ x] My pull request is based on the latest changes of the master branch.

  No? Unsure? -> execute command git pull --rebase upstream master

[debicki]

It seemed to me that such tickets would be too easy for you. ;)

However, you forgot to add the "RESTWS-813:" tag to the commit description:

Additionally, I am curious what tests have you added? : P
From the description of PR:

[HerbertYiga]

@insookwa Add a ticket Id to your commit,https://wiki.openmrs.org/display/docs/Pull+Request+Tips

[debicki]

@insookwa Are you still working on it?

[insookwa]

oh, can I make another commit including the ticket ID to have this closed ? about the tests i added none @sacull

[insookwa]

It seemed to me that such tickets would be too easy for you. ;)

However, you forgot to add the "RESTWS-813:" tag to the commit description:

Additionally, I am curious what tests have you added? : P
From the description of PR:

Thanks @sacull i have made a rebase and edited the commit message . please review and revert

[dkayiwa]

review and revert

revert or merge 😊

[debicki]

i have made a rebase and edited the commit message

If so, only locally, because PR still contains commit from September. Additionally, there is some conflict, so you will have to resolve it.

[insookwa]

review and revert

revert or merge

work in progress

[insookwa]

i have made a rebase and edited the commit message

If so, only locally, because PR still contains commit from September. Additionally, there is some conflict, so you will have to resolve it.

@sacull please en light me about the conflict . how can i solve it

[debicki]

The easiest way to use Github.

Delete lines 1040, 1043-1045:

You'll probably get on with it. This is the easiest method, but not necessarily the best. ;)

[debicki]

Suggested change

	if (operationName.equals("post") || operationName.equals("get")) {
	// createDefinition(operationEnum, resourceName, resourceParentName, representation);
	createDefinition(operationEnum, resourceName, resourceParentName, resourceHandler);
	if (operationName.equals("post") || operationName.equals("get")) {
	// createDefinition(operationEnum, resourceName, resourceParentName, representation);
	createDefinition(operationEnum, resourceName, resourceParentName, resourceHandler);

Don't you think these blank lines are unnecessary?

[debicki]

And is this code in the comment needed? Does it have any meaning for the source code?

[debicki]

Suggested change

	if (operationName == "post" || operationName == "get") {

This fragment should be removed, otherwise, the code will not compile.

[njiddasalifu]

Hi @dkayiwa can I continue work on this issue. I see it cosed