Skip to content

RESTWS-964 - Error when trying to run webservices modules > 2.44#640

Closed
mseaton wants to merge 1 commit intomasterfrom
RESTWS-964
Closed

RESTWS-964 - Error when trying to run webservices modules > 2.44#640
mseaton wants to merge 1 commit intomasterfrom
RESTWS-964

Conversation

@mseaton
Copy link
Member

@mseaton mseaton commented Jan 27, 2025

@coveralls
Copy link

Coverage Status

coverage: 47.645% (-0.06%) from 47.704%
when pulling 22fdb13 on RESTWS-964
into 381dae8 on master.

@dkayiwa
Copy link
Member

dkayiwa commented Jan 27, 2025

@mseaton i remember you having fixed this sometime back and i thought we had merged it. But only to find it still unmerged here: #635

Copy link
Member

@mogoodrich mogoodrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @mseaton !

Collection<Provider> providers = new HashSet<Provider>();
try {
Context.addProxyPrivilege(PrivilegeConstants.VIEW_PROVIDERS);
Context.addProxyPrivilege(GET_PROVIDERS_PRIVILEGE);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: also include the comment above here, as this is where people would most likely be scratching their heads?

@mseaton
Copy link
Member Author

mseaton commented Jan 28, 2025

@mseaton i remember you having fixed this sometime back and i thought we had merged it. But only to find it still unmerged here: #635

Wow - at least my solution was the same each time! Thanks @dkayiwa - I went ahead and merged the other one. Will close this one.

@mseaton mseaton closed this Jan 28, 2025
@mseaton mseaton deleted the RESTWS-964 branch January 28, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants