Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the conditional "New Chat" button functionality by eliminating the enableNewChat prop and related logic throughout the codebase. The new chat button is now always enabled instead of being conditionally disabled based on whether messages exist in the current chat.
- Removed
enableNewChatprop from all components in the assistant UI hierarchy - Simplified component interfaces by removing boolean flag and related state management
- Removed story that demonstrated disabled new chat functionality
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| assistant-top-bar.stories.tsx | Removed enableNewChat prop from stories and deleted the disabled new chat story |
| assistant-ui-chat-container.tsx | Removed enableNewChat prop from component interface and usage |
| assistant-top-bar.tsx | Removed enableNewChat prop and disabled state from new chat button |
| step-settings-assistant-ui-chat-container.tsx | Removed enableNewChat prop from component interface |
| step-settings-assistant-ui-chat.tsx | Removed enableNewChat prop usage and hasMessages dependency |
| assistant-ui-chat-hook.ts | Removed hasMessages state tracking and related logic |
| assistant-ui-chat.tsx | Removed enableNewChat prop usage and hasMessages dependency |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes OPS-2340