Fix Searchable select text overlap#1525
Merged
rSnapkoOpenOps merged 2 commits intomainfrom Oct 28, 2025
Merged
Conversation
rSnapkoOpenOps
commented
Oct 23, 2025
| loading={loading} | ||
| aria-expanded={open} | ||
| className="w-full justify-between w-full" | ||
| className="w-full justify-between" |
Collaborator
Author
There was a problem hiding this comment.
Just removed duplicate
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a text overlap issue in the SearchableSelect component where the selected text was overlapping with the refresh button. The fix involves:
- Removing duplicate
w-fullclass from the trigger button - Adding proper spacing and text truncation controls to the label span
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
packages/react-ui/src/app/common/components/searchable-select.tsx
Outdated
Show resolved
Hide resolved
|
alexandrudanpop
approved these changes
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes OPS-2905.