Fix text wrap on condition fields#1527
Merged
rSnapkoOpenOps merged 3 commits intomainfrom Oct 28, 2025
Merged
Conversation
rSnapkoOpenOps
commented
Oct 23, 2025
Comment on lines
+117
to
+122
| 'w-full rounded-md border border-input bg-background px-3 py-2 text-sm ring-offset-background file:border-0 file:bg-transparent file:text-sm file:font-medium placeholder:text-muted-foreground focus-visible:outline-none focus-visible:ring-1 focus-visible:ring-ring focus-visible:ring-offset-1 disabled:cursor-not-allowed disabled:opacity-50', | ||
| textMentionUtils.inputThatUsesMentionClass, | ||
| { | ||
| 'cursor-not-allowed opacity-50': disabled, | ||
| }, | ||
| className, |
Collaborator
Author
There was a problem hiding this comment.
Custom class name was not used, so it's safe to change
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes text wrapping issues in condition input fields by adjusting horizontal padding. The fix ensures that text content in condition fields wraps properly without overflow.
Key Changes:
- Added
px-1className to TextInputWithMentions components in condition settings - Repositioned className prop in TextInputWithMentions to allow overriding default padding
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| packages/react-ui/src/app/features/builder/step-settings/split-settings/single-condition.tsx | Added px-1 className to both TextInputWithMentions instances to reduce horizontal padding |
| packages/react-ui/src/app/features/builder/step-settings/branch-settings/branch-single-condition.tsx | Added px-1 className to both TextInputWithMentions instances to reduce horizontal padding |
| packages/react-ui/src/app/features/builder/block-properties/text-input-with-mentions/index.tsx | Moved className prop after default classes to allow padding override |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
packages/react-ui/src/app/features/builder/step-settings/split-settings/single-condition.tsx
Show resolved
Hide resolved
packages/react-ui/src/app/features/builder/step-settings/split-settings/single-condition.tsx
Outdated
Show resolved
Hide resolved
.../react-ui/src/app/features/builder/step-settings/branch-settings/branch-single-condition.tsx
Show resolved
Hide resolved
.../react-ui/src/app/features/builder/step-settings/branch-settings/branch-single-condition.tsx
Outdated
Show resolved
Hide resolved
…h-settings/branch-single-condition.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…-settings/single-condition.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
alexandrudanpop
approved these changes
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes OPS-2919.