Fix CLI new chat handling#1591
Merged
alexandrudanpop merged 2 commits intomainfrom Nov 11, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes CLI new chat handling by improving the chat ID management when creating new chats in step settings mode. The key improvement is ensuring that when a new chat is created, the chat ID is properly updated and propagated.
Key Changes:
- Extracted step ID logic into a reusable helper function
- Added chat ID update after opening a new conversation in step settings mode
- Fixed dependency array to include
stepDetailsto ensure proper cleanup behavior
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
cezudas
approved these changes
Nov 11, 2025
maor-rozenfeld
pushed a commit
that referenced
this pull request
Nov 11, 2025
<!-- Ensure the title clearly reflects what was changed. Provide a clear and concise description of the changes made. The PR should only contain the changes related to the issue, and no other unrelated changes. --> Fixes OPS-2979
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes OPS-2979