Revert "Pass workspaceId to Tables iframe via parentData for dashboard filtering"#1627
Revert "Pass workspaceId to Tables iframe via parentData for dashboard filtering"#1627
Conversation
…d filter…" This reverts commit a279500.
There was a problem hiding this comment.
Pull Request Overview
This PR reverts changes that passed workspaceId to the Tables iframe via parentData for dashboard filtering (related to OPS-3008). The revert removes the logic that retrieved workspaceId from either the project or organization context and simplified the parentData object back to only include Candu-related properties.
Key changes:
- Removed project and platform hooks that were used to fetch workspaceId
- Simplified parentData object to only include Candu properties (isCanduEnabled, userId, canduClientToken)
- Removed workspaceId retrieval logic and type assertions
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| const parentData = encodeURIComponent(JSON.stringify(parentDataObj)); | ||
| const parentData = encodeURIComponent( | ||
| JSON.stringify({ isCanduEnabled, userId: canduUserId, canduClientToken }), |
There was a problem hiding this comment.
The parentData object includes isCanduEnabled directly without conditionally checking if Candu is enabled. This differs from the reverted code which only included isCanduEnabled: true when it was actually enabled. If isCanduEnabled is false, it will now be passed as false rather than being omitted, which may cause unintended behavior in the iframe.
| JSON.stringify({ isCanduEnabled, userId: canduUserId, canduClientToken }), | |
| JSON.stringify({ | |
| ...(isCanduEnabled ? { isCanduEnabled: true } : {}), | |
| userId: canduUserId, | |
| canduClientToken, | |
| }), |
|
Reverts #1609
Part of OPS-3008.