Set tables workspace selection cookie upon user signup/signin#1628
Merged
Set tables workspace selection cookie upon user signup/signin#1628
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements functionality to set the tables workspace selection cookie (baserow_group_id) when users sign up or sign in. The changes ensure that the workspace ID is passed through the authentication flow and stored as a cookie alongside the existing authentication tokens.
Key Changes
- Added
tablesWorkspaceIdfield to authentication response types - Updated cookie handling to conditionally set
baserow_group_idcookie during authentication - Updated cookie cleanup to remove
baserow_group_idon sign out
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/shared/src/lib/authentication/dto/authentication-response.ts | Added optional tablesWorkspaceId field to authentication response type |
| packages/server/api/src/app/authentication/context/authentication-cookies.ts | Implemented conditional setting and clearing of baserow_group_id cookie |
| packages/server/api/src/app/authentication/basic/authentication-service.ts | Populated tablesWorkspaceId field in authentication response |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ion-cookies.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
| .send(response); | ||
| }); | ||
|
|
||
| if (response.tablesWorkspaceId !== undefined) { |
Contributor
There was a problem hiding this comment.
The value should not be optional. We generate the tokens so we have an workspaceId
|
MarceloRGonc
approved these changes
Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of OPS-3008.