Update login form for federated logout#1644
Merged
alexandrudanpop merged 5 commits intomainfrom Nov 20, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the sign-in form to support federated logout functionality by integrating feature flags and modifying the logout behavior on component mount.
Key changes:
- Replaces
useEffectOncewithuseEffectto handle feature flag dependencies - Adds
federatedLoginUrlparameter to logout call using theFRONTEGG_URLfeature flag - Introduces early return when flags are not yet loaded
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
| authenticationSession.logOut({ | ||
| userInitiated: false, | ||
| federatedLoginUrl: flags?.FRONTEGG_URL as string | undefined, |
Contributor
There was a problem hiding this comment.
Won't this interfere with cloud templates?
Contributor
Author
There was a problem hiding this comment.
no because in OSS we don't have FRONTEGG_URL setup
Contributor
There was a problem hiding this comment.
We have If OPS_CLOUD_CONNECTION_PAGE_ENABLED is enabled
…ign-in-form.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
… into chore/logout
|
MarceloRGonc
approved these changes
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes OPS-2947
Need it for federated login