Update guard and interceptors to prevent conflicts

[alexandrudanpop]

Fixes OPS-3144

[linear]

OPS-3144 Add federated bootstrap logic

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch chore/sync-internal

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This PR updates the authentication interceptor setup to prevent conflicts by ensuring interceptors are only initialized once with the correct configuration. The key change is removing the automatic initialization of the request interceptor and instead deferring both request and response interceptor setup until flags are available.

• Moved request interceptor initialization to be controlled by the guard component
• Added state management to ensure interceptors are ready before rendering children
• Updated type signatures to align federated and standard response interceptor interfaces

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
packages/react-ui/src/app/interceptors/response-interceptor.ts	Updated federated response interceptor return type to match standard interceptor
packages/react-ui/src/app/interceptors/index.ts	Exported setupRequestInterceptor and consolidated type definitions
packages/react-ui/src/app/common/guards/intial-data-guard.tsx	Added controlled interceptor initialization with loading state

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The interceptorsReady check will block rendering even when flags is undefined. This creates a situation where if flags never load, the application will show a loading spinner indefinitely instead of handling the error state. Consider checking both flags and interceptorsReady, or handling the flags error case differently.

[Copilot]

Self-closing tag should be used for components without children. Replace </LoadingSpinner> with /> to follow React conventions.

[cezudas]

1min fix, looks legit.

[greptile-apps]

Greptile Overview

Greptile Summary

Prevented race condition where API calls could execute before Axios interceptors were configured by moving interceptor setup from module-level initialization to controlled setup within InitialDataGuard.

Key changes:

• Request interceptor now requires explicit setup with isFederatedAuth flag instead of auto-initializing on module import
• Added interceptorsReady state to block children rendering until both request and response interceptors are configured
• Unified type naming from ResponseInterceptorOptions to InterceptorOptions for consistency
• Corrected TypeScript return type for createFederatedResponseInterceptor to match actual signature

Confidence Score: 4/5

• This PR is safe to merge with one edge case to monitor
• The changes effectively solve the race condition by ensuring interceptors are configured before children render. The implementation is sound, but there's an edge case where if flags fail to load (null/undefined), users will see an infinite loading spinner rather than a proper error state.
• Pay attention to intial-data-guard.tsx - monitor error handling for flags loading failures in production

Important Files Changed

File Analysis

Filename	Score	Overview
packages/react-ui/src/app/common/guards/intial-data-guard.tsx	4/5	Added state management to ensure interceptors are setup before rendering children, preventing race conditions where API calls occur before interceptors are configured
packages/react-ui/src/app/interceptors/index.ts	5/5	Removed auto-initialization of request interceptor and made it explicitly configurable, unified type names for consistency
packages/react-ui/src/app/interceptors/response-interceptor.ts	5/5	Updated return type signature for federated response interceptor to match actual implementation

Sequence Diagram

sequenceDiagram
    participant App
    participant InitialDataGuard
    participant FlagsAPI
    participant Interceptors
    participant AxiosInstance
    participant Children

    App->>InitialDataGuard: Render with children
    InitialDataGuard->>FlagsAPI: useFlags() (useSuspenseQuery)
    Note over InitialDataGuard,FlagsAPI: Suspends until flags loaded
    FlagsAPI-->>InitialDataGuard: Returns flags data
    
    alt flags is null/undefined
        InitialDataGuard->>InitialDataGuard: console.error + return early
        InitialDataGuard->>InitialDataGuard: Show LoadingSpinner (interceptorsReady=false)
    else flags exists
        InitialDataGuard->>Interceptors: setupRequestInterceptor({isFederatedAuth})
        Interceptors->>AxiosInstance: Register request interceptor
        AxiosInstance-->>Interceptors: interceptorId
        InitialDataGuard->>Interceptors: setupResponseInterceptor({isFederatedAuth})
        Interceptors->>AxiosInstance: Register response interceptor
        AxiosInstance-->>Interceptors: interceptorId
        InitialDataGuard->>InitialDataGuard: setInterceptorsReady(true)
        InitialDataGuard->>Children: Render children (with Suspense)
        Children->>AxiosInstance: Make API calls
        Note over AxiosInstance,Children: Interceptors now active
    end

Loading

[greptile-apps]

_{3 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud