Refactor tool handling: remove UI tool checks #1846
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndAutomaticallyWhen` logic.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors tool handling by removing custom UI tool prefix checks and simplifying the code to use built-in functionality from the ai library. The changes eliminate the need for manual tool call detection logic in favor of standardized approaches.
Changes:
- Removed custom
stopWhencondition that checked for UI tool prefixes in the LLM stream handler - Replaced custom
sendAutomaticallyWhenlogic with the built-inlastAssistantMessageIsCompleteWithToolCallsfunction - Cleaned up unused imports related to UI tool detection
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/server/api/src/app/ai/chat/llm-stream-handler.ts | Simplified stopWhen conditions by removing UI tool prefix check and cleaned up related imports |
| packages/react-ui/src/app/features/ai/lib/assistant-ui-chat-hook.ts | Replaced custom auto-send logic with built-in lastAssistantMessageIsCompleteWithToolCalls function |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
alexandrudanpop
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes OPS-3293