Add project context to analytics access verification #1855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds project context to analytics access verification by including projectId as a parameter throughout the analytics authentication flow. The change enables access verification to be scoped to specific projects rather than just users.
Changes:
- Updated analytics authentication service to accept and pass
projectIdparameter - Modified analytics access service interface and implementation to include
projectIdin verification - Updated controller calls to provide
projectIdfrom request principal
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| authentication.controller.ts | Passes projectId from request principal to analytics authentication service |
| access-service.ts | Updated stub implementation to remove unused parameter |
| access-service-factory.ts | Added projectId parameter to service interface type definition |
| analytics-authentication-service.ts | Updated to accept and forward projectId to access verification |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/server/api/src/app/authentication/analytics/access-service.ts
Outdated
Show resolved
Hide resolved
cezudas
force-pushed
the
cezudas/OPS-3446
branch
from
e2bd661 to
d1b262a
Compare
|
MarceloRGonc
approved these changes
Jan 19, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes OPS-3446.