Make benchmark ready footer buttons wrap with container queries#2051
Merged
Make benchmark ready footer buttons wrap with container queries#2051
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the layout of the footer buttons in the "benchmark-ready" wizard phase, making them wrap responsively using CSS container queries instead of always displaying inline.
Changes:
- Added
@containerandflex-wrapto the footer wrapper div so buttons wrap at narrow container widths - Added responsive classes (
flex-1 min-w-0 @xs:flex-none/w-full @xs:w-auto) to all three footer buttons for proper narrow/wide behavior - Added a
classNameprop toViewBenchmarkWorkflowsButtonto allow passing layout-specific styles from the parent
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
benchmark-wizard-footer.tsx |
Adds @container, flex-wrap, and responsive classes to footer wrapper and buttons |
view-benchmark-workflows-button.tsx |
Exposes optional className prop to allow external layout styling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
|
alexandrudanpop
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes OPS-3820.
Screenshots below, matching the latest Figma design (see ticket).
Narrow container:
Wide container:
