Make benchmark-ready "Available workflows" list use available vertical space#2058
Make benchmark-ready "Available workflows" list use available vertical space#2058
Conversation
cezudas
requested review from
alexandrudanpop,
Copilot,
ravikiranvm and
rmn-snpk
|
There was a problem hiding this comment.
Pull request overview
Updates the benchmark “Available workflows” section layout so the workflow list can scroll and better utilize vertical space in the “benchmark-ready” wizard step (OPS-3845).
Changes:
- Makes
BenchmarkWorkflowLista flex column container intended to grow within its parent and prevents the disclaimer text from shrinking. - Updates the “benchmark-ready”
WizardStepto be a flex column withflex-1 min-h-0so its children can participate in height-based layouts/scrolling.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/ui-components/src/components/benchmark/benchmark-workflow-list.tsx | Adjusts container/list/disclaimer flex + overflow classes to support using available vertical space. |
| packages/react-ui/src/app/features/benchmark/components/benchmark-wizard.tsx | Makes the benchmark-ready wizard step a flex container so its content can size/scroll correctly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| <div className="flex flex-col flex-1 min-h-0"> | ||
| <p className="font-medium text-sm mb-2">{t('Available workflows:')}</p> | ||
| <ul className="list-disc pl-5 space-y-1 overflow-y-auto max-h-[120px]"> | ||
| <ul className="list-disc pl-5 space-y-1 overflow-y-auto min-h-0"> |
There was a problem hiding this comment.
BenchmarkWorkflowList is now a flex column container intended to use remaining vertical space, but the <ul> doesn’t have flex-1/grow, so it won’t expand to fill available space (it will only shrink when constrained). If the goal is for the scrollable list to take all remaining height and keep the italic note pinned to the bottom, make the <ul> a growing flex child (e.g., add flex-1 alongside min-h-0).
| <ul className="list-disc pl-5 space-y-1 overflow-y-auto min-h-0"> | |
| <ul className="list-disc pl-5 space-y-1 overflow-y-auto min-h-0 flex-1"> |
Fixes OPS-3845.
https://www.loom.com/share/ade634d9e8674c8fac918415273af4a0