Skip to content

Add permission checks for connection picker #2089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexandrudanpop merged 1 commit into from
Mar 10, 2026
Merged

Add permission checks for connection picker #2089

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 53 additions & 21 deletions ...ages/react-ui/src/app/features/builder/step-settings/block-settings/connection-select.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import {
} from '@openops/components/ui';
import {
addConnectionBrackets,
Permission,
removeConnectionBrackets,
} from '@openops/shared';
import { t } from 'i18next';
Expand All @@ -23,6 +24,7 @@ import type React from 'react';
import { memo, useCallback, useState } from 'react';
import { ControllerRenderProps, useFormContext } from 'react-hook-form';

import { useAuthorization } from '@/app/common/hooks/authorization-hooks';
import { AutoFormFieldWrapper } from '@/app/features/builder/block-properties/auto-form-field-wrapper';
import { DynamicFormValidationProvider } from '@/app/features/builder/dynamic-form-validation/dynamic-form-validation-context';

Expand Down Expand Up @@ -50,6 +52,9 @@ const ConnectionSelect = memo((params: ConnectionSelectProps) => {
string | null
>(null);

const { checkAccess } = useAuthorization();
const canWriteConnection = checkAccess(Permission.WRITE_APP_CONNECTION);

Comment thread
alexandrudanpop marked this conversation as resolved.
const form = useFormContext();
const {
data: connectionsPage,
Expand Down Expand Up @@ -188,7 +193,7 @@ const ConnectionSelect = memo((params: ConnectionSelectProps) => {

{field.value && !field.disabled && !params.disabled && (
<div className="shrink-0 flex items-center gap-1">
{selectConnectionOpen && (
{selectConnectionOpen && canWriteConnection && (
<Button
type="button"
variant="ghost"
Expand Down Expand Up @@ -229,30 +234,15 @@ const ConnectionSelect = memo((params: ConnectionSelectProps) => {
)}
</SelectTrigger>
<SelectContent>
<SelectAction
onClick={() => {
<ConnectionSelectContent
canWriteConnection={canWriteConnection}
connections={connectionsPage?.data ?? []}
onCreateNew={() => {
setReconnectConnectionId(null);
setSelectConnectionOpen(false);
setConnectionDialogOpen(true);
}}
>
<span className="flex items-center gap-1 text-primary w-full">
<Plus size={16} />
{t('Create new connection')}
</span>
</SelectAction>

{connectionsPage?.data &&
connectionsPage.data.map((connection) => {
return (
<SelectItem
value={addConnectionBrackets(connection.name)}
key={connection.name}
>
{connection.name}
</SelectItem>
);
})}
/>
</SelectContent>
</Select>
</AutoFormFieldWrapper>
Expand All @@ -263,5 +253,47 @@ const ConnectionSelect = memo((params: ConnectionSelectProps) => {
);
});

type ConnectionSelectContentProps = {
canWriteConnection: boolean;
connections: { name: string }[];
onCreateNew: () => void;
};

const ConnectionSelectContent = ({
canWriteConnection,
connections,
onCreateNew,
}: ConnectionSelectContentProps) => {
if (connections.length === 0 && !canWriteConnection) {
return (
<div className="px-3 py-2 text-sm text-muted-foreground">
{t('No available connections')}
</div>
);
}

return (
<>
{canWriteConnection && (
<SelectAction onClick={onCreateNew}>
<span className="flex items-center gap-1 text-primary w-full">
<Plus size={16} />
{t('Create new connection')}
</span>
</SelectAction>
)}

{connections.map((connection) => (
<SelectItem
value={addConnectionBrackets(connection.name)}
key={connection.name}
>
{connection.name}
</SelectItem>
))}
</>
);
};

ConnectionSelect.displayName = 'ConnectionSelect';
export { ConnectionSelect };
Loading