fix(workflow): fall back on malformed render details - #102
Merged
Conversation
Guard the Workflow custom renderer against generic Pi error details so parse failures remain visible as text instead of crashing the TUI. Add regression coverage for empty and incomplete details without spinner activity.\n\nCloses #101
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
workflowtool-result details before entering the custom card rendererWhy
Pi represents some extension-tool execution failures with
isError: trueanddetails: {}. The Workflow renderer previously treated every truthydetailsvalue asWorkflowDetails, then calledaggregateUsage(details.agents). A Workflow parse error therefore became an uncaughtTypeError: agents is not iterableand terminated the TUI.The fix checks the mandatory top-level Workflow render contract (
runId,background, terminal/running status, finitestartedAt,phases, andagents) before using the custom renderer. Invalid shapes preserve the original error text and do not start a spinner. Valid Workflow cards are unchanged.Test plan
node --test --experimental-strip-types extensions/workflows/rendering.test.tsbun run checkbun run test— 868 Node tests and 30 Vitest tests passedgit diff --checkCloses #101