Fix npm install startup failure without ioredis - #3
Conversation
ReviewP0 — correctness / architectureNo actionable findings. The focused P1 — tests / package contractNo actionable findings. CI passes on Node 22.19 and 24, and the runtime import guard prevents the root barrel from returning. Independent clean-install verification:
|
Follow-up review correctionThe runtime fix remains correct and the independent clean-install E2E passed. One P1 test gap remains: Recommended before merge: add an isolated packed-install subprocess smoke that installs with optional peers omitted and starts both |
- claude: drop forced permissionMode/allowDangerouslySkipPermissions. With settingSources omitted the SDK loads the user's Claude Code settings (CLI-default behavior), so subagents keep exactly the permission mode the user runs with in their terminal. - codex: drop forced approvalPolicy/sandbox from thread/start so the thread inherits the user's config.toml; the decline handler remains as the headless answer if that config still asks for approvals. - codex: cap the optional model/list effort-clamp probe at 5s so a slow/unsupported server cannot hold a spawn (and its concurrency reservation) for the full 30s request timeout (Greptile P2). Addresses PR openpi-dev#3 review: permission behavior is now inherit-by-design rather than override; pi already inherited via its child-session trust gating.
subagents-v2: Effect v4 multi-harness subagent system (pi, Claude Code, Codex)
…redis Fix npm install startup failure without ioredis
两条不相交历史(lazyload 开发库独立根)。分支 296 提交为演化主线, 内容取代 origin/main 的 PR openpi-dev#3/openpi-dev#5/openpi-dev#7/openpi-dev#9(Redis 可选依赖、Biome/Bun 对齐、任务对账、批量通知——分支已含演化版:shared/task-reconcile、 result-delivery、biome/bun 工具链)。 - 冲突与内容一律取分支侧;合并树 == 分支树(read-tree 落地后 diff 为空校验通过;merge 自动解析曾引入 main 侧旧位置 subagents/src/agent-types.ts 残留,已随精确落地清除——该模块 在分支 c7017af DDD 收敛时迁至 shared/) - 本地 main 未推送的 2 个提交(commit-task-sync v2 + obsidian KB) 存档于 archive/local-main-unpushed;vault 内容按 d0e64d4 决策不并入 - 分支关键内容:工具载荷 40.6k→~36.0k tok(端到端 -10.5%)、加载组 预设、B 方案第三方描述补丁、显示残留根治(model-info tok/s、 session-liveness busy 闸门 + 子会话守卫)、总线漂移守卫、 agent-types 诊断分级
Summary
Verification
npm run format:checknpm run checknpm test(591 Node tests and 29 Vitest tests)--legacy-peer-deps; confirmedioredisis absentpi install --localand launched Pi 0.82.1; all OpenPI extensions, includingfile-searchandgit-info, loaded successfullyCloses #2