Check only for existence of PMIx capability flag#2290
Merged
rhc54 merged 1 commit intoopenpmix:masterfrom Oct 24, 2025
Merged
Conversation
There was an initial thought that we would generate some uber-list of defined flags for capabilities across all PMIx versions, and then indicate which ones were supported by this particular version by OR'ing them together into some more general value. This has proven unworkable as you get into a giant game of bit-counting to create the definitions. Instead, we only define flags that this specific version supports - thus, the value of the individual flag is irrelevant and no general value is required. Signed-off-by: Ralph Castain <rhc@pmix.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was an initial thought that we would generate some uber-list of defined flags for capabilities across all PMIx versions, and then indicate which ones were supported by this particular version by OR'ing them together into some more general value. This has proven unworkable as you get into a giant game of bit-counting to create the definitions. Instead, we only define flags that this specific version supports - thus, the value of the individual flag is irrelevant and no general value is required.