Run check_config on methods too - #37
Merged
Merged
Conversation
* Add check_config.py to comp_method.yaml's test resources * Move documentation_url/repository_url to links in the four configs that still used the old placement * Give novel and simple_mlp a nextflow resource label Control methods and metrics were checked, methods were not, which is how the deprecated info.documentation_url survived in four configs.
8 tasks
* they are inert on a nextflow_script component, viash renders a workflow instead of a process * remove them once openproblems-bio/core#41 is released
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
comp_control_method.yamlandcomp_metric.yamlboth listcheck_config.pyin their test resources.comp_method.yamldoesn't -- so method metadata has never been validated. That's how four configs kept the deprecated placement:when
check_config()requireslinks.documentationandlinks.repositoryat the top level fortype: method. Moved them inknnr_py,knnr_r,lmandguanlab_dengkw_pm.Turning the check on also surfaced something pre-existing:
novelandsimple_mlphave a Nextflow runner with nodirectives, which tripssimple_mlpwas already failing this onmain-- it mergeswf_method.yaml, which has always hadcheck_config.py. It just never ran, because CI only tests components touched by a PR and nobody has touchedsimple_mlpin a while. Gave both wrappers a[lowtime, lowmem, lowcpu]label with a comment noting the real resources live on the train/predict sub-components.Ran
check_config()over every component after the change:Heads-up for the open method PRs (#16, #18, #19, #20): once this lands they'll need
links.documentationandlinks.repositorytoo. That's the point of the check, but worth flagging so it isn't a surprise.Part of a series of PRs coming out of a pre-run review of the benchmark.
Checklist before requesting a review
I have performed a self-review of my code
Check the correct box. Does this PR contain:
Proposed changes are described in the CHANGELOG.md
CI Tests succeed and look good!