Remake document's display checking test cases#259
Remake document's display checking test cases#259mykhaly merged 16 commits intoopenprocurement:develfrom mykhaly:devel
Conversation
|
В загальному твій підхід мені подобається, крім останнього коміту. Reviewed 2 of 2 files at r1, 3 of 3 files at r2, 1 of 1 files at r3, 3 of 3 files at r4. a discussion (no related file): a discussion (no related file): Як варіант – драйвери можуть повертати лише filename, а місце для збереження буде обговорено заздалегідь – наприклад, [0]: Або якщо їм так зручніше – file-like object. Поки що наш код це вміє, але якщо продовження підтримки FLO буде ускладнювати код, то можна підримку відпиляти. op_robot_tests/tests_files/base_keywords.robot, line 241 [r2] (raw file):
А от в op_robot_tests/tests_files/openProcedure.robot, line 470 [r3] (raw file):
Цей ківорд більше ніде не використовується. op_robot_tests/tests_files/service_keywords.py, line 417 [r1] (raw file):
Заміни op_robot_tests/tests_files/service_keywords.py, line 418 [r1] (raw file):
Чому op_robot_tests/tests_files/service_keywords.py, line 416 [r3] (raw file):
Може це варто перенести в op_robot_tests/tests_files/brokers/openprocurement_client.robot, line 46 [r2] (raw file):
Якщо ми послідовно отримуємо різну інформацію із документа (тим більше, з кількох), то чому б не закешувати ті дані? В брокерів, які працюють через сайт, є перевага – відкрита сторінка в браузері, з якої можна читати підряд різні дані і рефрешити лише коли потрібно. Чи це ускладнить код? op_robot_tests/tests_files/brokers/openprocurement_client.robot, line 57 [r4] (raw file):
👍 👍 👍 Comments from Reviewable |
|
Що не так з останнім комітом? Review status: 0 of 4 files reviewed at latest revision, 10 unresolved discussions. a discussion (no related file):
|
Оце:
Reviewed 4 of 4 files at r5, 3 of 3 files at r6, 1 of 1 files at r7, 3 of 3 files at r8, 1 of 1 files at r9, 1 of 1 files at r10, 2 of 2 files at r11, 1 of 1 files at r12. a discussion (no related file):
|
|
Review status: all files reviewed at latest revision, 4 unresolved discussions. a discussion (no related file):
|
|
Review status: 0 of 6 files reviewed at latest revision, 3 unresolved discussions. op_robot_tests/tests_files/service_keywords.py, line 417 [r7] (raw file):
|
|
Reviewed 5 of 6 files at r13, 1 of 1 files at r14, 1 of 1 files at r15, 1 of 5 files at r16, 3 of 4 files at r17, 1 of 1 files at r18, 1 of 1 files at r19, 1 of 1 files at r20, 1 of 1 files at r21, 2 of 2 files at r22, 1 of 1 files at r23, 1 of 1 files at r24. a discussion (no related file):
|
|
Review status: 0 of 6 files reviewed at latest revision, 4 unresolved discussions. a discussion (no related file):
|
Return path to created file, basename of created file and content of created file instead of name of created file (and path to it at the same time). It is made in order to delete file after uploading and save all useful data in Robot Framework variables.
Add ${doc_id} variable and get_id_from_doc_name function.
Use updated `create_fake_doc` function.
Use better names for variables.
Use id from title instead of url as data given to broker to find the document. Add new keyword `Отримати інформацію із документа` and use it instead of `Отримати інформацію із тендера`.
Add `get_document_by_id` and `get_file_basename` functions, because they
are needed in `Отримати документ` keyword.
Remove `get_file_contents` function call.
Remake `Отримати документ` keyword: now it returns only name of
downloaded by broker file in lieu of file content and path. Moreover,
`${url}` arguments is replaced with `${doc_id}` so as to give to broker
better data about document to download.
Now is used Robot Framework keyword `Get File`, so it is redundant
In order to work with new arguments returned from `create_fake_doc()`.
Also add `${doc_id}`, `${doc_name}` and `${doc_content}` to `${claim_data}`
and `Remove File` it the end of keywords body.
Call `Отримати інформацію із документа до скарги` directly from test case, without any shell. Rename `Отримати поле документації до скарги` -> `Отримати інформацію із документа до скарги` and remake algorithm inside it.
And remove file after uploading.
Also update saving those data returned from `create_fake_doc` into variable and add removing of file after uploading.
Remove useles row `${number_of_lots}= Get Length
${USERS.users[].initial_data.data.lots}` and use previously saved data
for checking document contents instead of reading that from file.
To work with changed `create_fake_doc` function. Also remove file after uploading, like in others keywords from base_keywords.robot.
To work with changed `create_fake_doc` function. Also remove file after uploading, like in others keywords from base_keywords.robot.
4 participants
Main things are to use
${doc_id}instead of${url}to find proper document and to remove file after uploading.This change is