ci: run the skill conformance gate on every pull request - #171
Merged
Conversation
The gate is about to become a required status check on main. A required check that is path-filtered never reports on a pull request outside the filter, and that pull request then waits forever on a check that will never arrive. The suites read Markdown off disk with no build step, no model key, and no network, so running them unconditionally costs well under a minute.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This job is about to become the required status check on
main. A path-filtered required check never reports on a pull request outside its filter, and GitHub has no "only if it ran" option — the pull request just waits on a check that will never arrive. Today that would strand anything touching onlyscripts/,CHANGELOG.md,.github/**,assets/,.version-bump.json,AGENTS.mdorRELEASE.md.Removing the filter is cheaper than adding an always-running aggregate job. The suites read Markdown off disk and make string assertions — no build step, no model key, no network — so running them unconditionally costs well under a minute. The Reactor repository's workflow is unfiltered for the same reason.
Nothing changes about what runs, only when. The job name is marked do-not-rename, since it is what the branch rule will reference.