Point remaining Maven instructions at the Code Genome Project - #535
Merged
Conversation
The rewrite-maven-plugin and the rewrite modules are no longer published to Maven Central; Central stops at rewrite-maven-plugin 6.46.1 and rewrite-core 8.90.4. A handful of Maven snippets still assumed they could be resolved without declaring the Code Genome Project repository. Snapshots now come from the same Code Genome Project repository rather than central.sonatype.com.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The plugin and the rewrite modules are no longer published to Maven Central. Verified against the live repositories:
org.openrewrite.maven:rewrite-maven-pluginorg.openrewrite:rewrite-core/rewrite-bomAnything still telling readers to add the plugin without declaring the Code Genome Project repository now sends them to a build that cannot resolve it.
What changed
reference/snapshot-instructions.md— snapshots now come fromhttps://artifacts.codegenomeproject.org/maven(with<snapshots><enabled>true</enabled></snapshots>) instead ofcentral.sonatype.com/repository/maven-snapshots, plus thesettings.xmlcredentials block. The "Maven Command Line" section now configuressettings.xmlrather than telling you to edit thepom.xmlit just said it would leave untouched.authoring-recipes/recipe-development-environment.md— the recipe module's own build had no<repositories>; the CGP snippets further down only covered the target project.authoring-recipes/recipe-testing.md,refaster-recipes.md,multiple-versions.md,writing-kotlin-recipes.md— pointers to the repository setup the dependency snippets assume.concepts-and-explanations/styles.md— the Maven POM tab had no note; only the CLI tab did.popular-recipe-guides/automating-maven-dependency-management.md— CGP setup step; also replaces a hardcoded5.41.0with{{VERSION_REWRITE_MAVEN_PLUGIN}}.popular-recipe-guides/authoring-declarative-yaml-recipes.md— pointer for both Maven tabs.Assumption to confirm
Snapshots are documented as living under the same
https://artifacts.codegenomeproject.org/mavenURL as releases. I could not verify this directly — every path under/mavenreturns 401 regardless of whether it exists — but there is no separate/maven-snapshotsor/snapshotsendpoint (both 404). Please correct me if snapshots have their own URL.Not included
Gradle is in a separate PR. There is also a cross-cutting cleanup worth doing later: CGP setup is currently deep-linked from three different anchors (
getting-started#step-2…,running-rewrite-on-a-maven-project-without-modifying-the-build#configure-…,latest-versions…#configure-…). Worth collapsing to one canonical section.Verification
yarn buildwithCI_STRICT_LINKS=1passes locally.