This repository was archived by the owner on May 12, 2025. It is now read-only.
add file-source handler#123
Merged
OlegDokuka merged 1 commit intomainfrom Oct 4, 2024
Merged
Conversation
knutwannheden
approved these changes
Oct 4, 2024
| } else { | ||
| generator.writeString("parse-javascript-file"); | ||
| generator.writeString(input.getPath().toString()); | ||
| generator.writeString(relativeTo.toString()); |
Contributor
There was a problem hiding this comment.
Whether we relativize the source file path on the Java or JS side doesn't really matter, I suppose.
Contributor
Author
There was a problem hiding this comment.
From what I learned, doing c# matters. CLI is the source of trues, so it knows what is the root dir and it better to pass it from that side
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
What's your motivation?
Anything in particular you'd like reviewers to focus on?
Anyone you would like to review specifically?
Have you considered any alternatives or workarounds?
Any additional context
Checklist