Skip to content
This repository was archived by the owner on May 12, 2025. It is now read-only.

add file-source handler #123

Merged
OlegDokuka merged 1 commit into from
Oct 4, 2024
Merged

add file-source handler #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ dependencies {

implementation(platform("org.openrewrite:rewrite-bom:$latest"))
implementation("org.openrewrite:rewrite-java")
implementation("org.openrewrite:rewrite-remote-java:latest.integration") {
implementation("org.openrewrite:rewrite-remote-java:$latest") {
exclude(group = "org.openrewrite", module = "rewrite-javascript")
}

Expand Down
1 change: 1 addition & 0 deletions src/main/java/org/openrewrite/javascript/JavaScriptParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ public Stream<SourceFile> parseInputs(Iterable<Input> inputs, @Nullable Path rel
} else {
generator.writeString("parse-javascript-file");
generator.writeString(input.getPath().toString());
generator.writeString(relativeTo.toString());
Copy link
Copy Markdown
Contributor

@knutwannheden knutwannheden Oct 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whether we relativize the source file path on the Java or JS side doesn't really matter, I suppose.

Copy link
Copy Markdown
Contributor Author

@OlegDokuka OlegDokuka Oct 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I learned, doing c# matters. CLI is the source of trues, so it knows what is the root dir and it better to pass it from that side

}
}, parser -> {
Tree tree = new ReceiverContext(remotingContext.newReceiver(parser), remotingContext).receiveTree(null);
Expand Down