Do not add final to a try-with-resources resource - #1232
Merged
greg-at-moderne merged 1 commit intoSep 3, 2026
Conversation
Contributor
Author
|
Ready for review @greg-at-moderne |
greg-at-moderne
self-requested a review
September 2, 2026 21:02
Contributor
Author
|
CI build is green. |
greg-at-moderne
approved these changes
Sep 3, 2026
greg-at-moderne
left a comment
Contributor
There was a problem hiding this comment.
Another great contribution. Thank you!
greg-at-moderne
force-pushed
the
lombok-val-try-with-resources
branch
from
September 3, 2026 11:43
fcc1c8a to
bfc708f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LombokValToFinalVarrewrotevaltofinal varunconditionally. Resources declared in a try-with-resources statement are already implicitly final, so the addedfinalmodifier is redundant there.This checks whether the variable declaration's parent is a
J.Try.Resourceand, if so, emits plainvarinstead offinal var.Adds a test covering the try-with-resources case.
🤖 Generated with Claude Code