-
Notifications
You must be signed in to change notification settings - Fork 109
Add missing method impl interface #460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing method impl interface #460
Conversation
- Add tests for AddMissingMethodImplementation Fixes openrewrite#459
- Add tests for AddMissingMethodImplementation Fixes openrewrite#459
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions could not be made:
- src/main/java/org/openrewrite/java/migrate/AddMissingMethodImplementation.java
- lines 18-19
- lines 31-30
src/test/java/org/openrewrite/java/migrate/AddMissingMethodImplementationTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/openrewrite/java/migrate/AddMissingMethodImplementationTest.java
Show resolved
Hide resolved
…lementationTest.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…lementationTest.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
src/test/java/org/openrewrite/java/migrate/AddMissingMethodImplementationTest.java
Outdated
Show resolved
Hide resolved
Add back missing import of Test Fixes openrewrite#459
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions could not be made:
- src/main/java/org/openrewrite/java/migrate/AddMissingMethodImplementation.java
- lines 18-19
- lines 31-30
src/test/java/org/openrewrite/java/migrate/AddMissingMethodImplementationTest.java
Outdated
Show resolved
Hide resolved
|
@timtebeek UpdateBeanManagerMethodsTest > fireEvent() is failing for both of the PR's so this doesn't look like anything to do with my changes. FWIW, the tests all pass for me locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions could not be made:
- src/main/java/org/openrewrite/java/migrate/AddMissingMethodImplementation.java
- lines 18-19
- lines 31-30
src/test/java/org/openrewrite/java/migrate/AddMissingMethodImplementationTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions could not be made:
- src/main/java/org/openrewrite/java/migrate/AddMissingMethodImplementation.java
- lines 18-19
- lines 31-30
timtebeek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for adding the tests here in addition to fixing the underlying issue. It seems our automated PR review was thrown off a bit when correcting the imports; we expect to see the static imports added after any regular imports, whereas your IDE settings seem to put them first. No problem at all; we'll fix that on PRs as they come in. Glad to have you on board here!
What's changed?
What's your motivation?
Fixes #459
Checklist