-
Notifications
You must be signed in to change notification settings - Fork 109
Add missing method impl interface #460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
timtebeek
merged 9 commits into
openrewrite:main
from
darylrobbins:add-missing-method-impl-interface
Apr 20, 2024
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
c1ccfb3
fix: Avoid adding method impls to interfaces
darylrobbins 62ea711
fix: Avoid adding method impls to interfaces
darylrobbins 2bbf704
Update src/test/java/org/openrewrite/java/migrate/AddMissingMethodImp…
darylrobbins 438ee0e
Update src/test/java/org/openrewrite/java/migrate/AddMissingMethodImp…
darylrobbins de3fa38
Apply suggestions from code review
timtebeek acad6a0
fix: Avoid adding method impls to interfaces
darylrobbins 3ffbc5c
Merge branch 'main' into add-missing-method-impl-interface
timtebeek e07bbab
Update AddMissingMethodImplementationTest.java
timtebeek e8075d5
Update AddMissingMethodImplementation.java
timtebeek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
136 changes: 136 additions & 0 deletions
136
src/test/java/org/openrewrite/java/migrate/AddMissingMethodImplementationTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,136 @@ | ||
| /* | ||
| * Copyright 2024 the original author or authors. | ||
| * <p> | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * <p> | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * <p> | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.openrewrite.java.migrate; | ||
|
|
||
| import org.junit.jupiter.api.Test; | ||
| import org.openrewrite.DocumentExample; | ||
| import org.openrewrite.Issue; | ||
| import org.openrewrite.test.RecipeSpec; | ||
| import org.openrewrite.test.RewriteTest; | ||
|
|
||
| import static org.openrewrite.java.Assertions.java; | ||
| import static org.openrewrite.java.Assertions.javaVersion; | ||
|
|
||
| class AddMissingMethodImplementationTest implements RewriteTest { | ||
|
|
||
| @Override | ||
| public void defaults(RecipeSpec spec) { | ||
| spec.recipe( | ||
| new AddMissingMethodImplementation("I1", "*..* m1()", | ||
| "public void m1() { System.out.println(\"m1\"); }")) | ||
| .allSources(src -> src.markers(javaVersion(21))); | ||
| } | ||
|
|
||
| @Test | ||
| @Issue("https://github.com/openrewrite/rewrite-migrate-java/issues/459") | ||
| void skipInterfaces() { | ||
| //language=java | ||
| rewriteRun( | ||
| java( | ||
| """ | ||
| interface I1 {} | ||
| interface I2 extends I1 {} | ||
| """ | ||
| ) | ||
| ); | ||
| } | ||
|
|
||
| @Test | ||
| void skipAbstractClasses() { | ||
| //language=java | ||
| rewriteRun( | ||
| java( | ||
| """ | ||
| interface I1 {} | ||
| abstract class AC2 implements I1 {} | ||
| """ | ||
| ) | ||
| ); | ||
| } | ||
|
|
||
| @DocumentExample | ||
| @Test | ||
| void happyPath() { | ||
| //language=java | ||
| rewriteRun( | ||
| java( | ||
| """ | ||
| interface I1 {} | ||
| class C2 implements I1 {} | ||
| """, | ||
| """ | ||
| interface I1 {} | ||
| class C2 implements I1 { | ||
| public void m1() { | ||
| System.out.println("m1"); | ||
| }} | ||
| """ | ||
| ) | ||
| ); | ||
| } | ||
|
|
||
| @Test | ||
| void methodExists() { | ||
| //language=java | ||
| rewriteRun( | ||
| java( | ||
| """ | ||
| interface I1 {} | ||
| class C2 implements I1 { | ||
| public void m1() { | ||
| System.out.println("m1"); | ||
| } | ||
| } | ||
| """ | ||
| ) | ||
| ); | ||
| } | ||
|
|
||
| @Test | ||
| void methodExistsDiffImpl() { | ||
| //language=java | ||
| rewriteRun( | ||
| java( | ||
| """ | ||
| interface I1 {} | ||
| class C2 implements I1 { | ||
| public void m1() { | ||
| System.out.println("m1 diff"); | ||
| } | ||
| } | ||
| """ | ||
| ) | ||
| ); | ||
| } | ||
|
|
||
| @Test | ||
| void methodExistsDiffSignature() { | ||
| //language=java | ||
| rewriteRun( | ||
| java( | ||
| """ | ||
| interface I1 {} | ||
| class C2 implements I1 { | ||
| protected void m1() { | ||
| System.out.println("m1"); | ||
| } | ||
| } | ||
| """ | ||
| ) | ||
| ); | ||
| } | ||
|
|
||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.