Rename the third isolated-projects property deprecated in Gradle 9.7 - #8410
Merged
Conversation
`MigrateIsolatedProjectsProperties` covered only two of the three `org.gradle.unsafe.isolated-projects*` properties that Gradle 9.7 promotes out of the `unsafe` namespace, missing `dangerously-ignore-problems`. Since the underlying `ChangePropertyKey` runs with `relaxedBinding: false` it matches whole keys, so the parent entry did not cover it by prefix. Follow-up to #8381.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gradle 9.7 promotes three
org.gradle.unsafe.isolated-projects*properties out of theunsafenamespace, butMigrateIsolatedProjectsPropertiesonly covered two of them, missingdangerously-ignore-problems.The parent entry does not cover it by prefix either: the underlying
ChangePropertyKeyruns withrelaxedBinding: false, which compiles toNameCaseConvention.EXACTand matches whole keys, so a build using the "dangerously ignore" mode would have kept a deprecated property name.Adds the missing rename, extends the
@DocumentExampleto cover all three properties, and regeneratesrecipes.csv.