Remove dead native-image visitor guard from Py.accept - #8419
Merged
Conversation
Py.accept short-circuited any visitor whose class name started with io.moderne.serialization., returning the node unvisited to avoid runtime visitor adaptation under a GraalVM native image. There is no native-image build anymore, so the guard is dead code — and it silently prevented JavaVisitor-based tooling (recipes, symbol indexing) from traversing Python LSTs, unlike JS and C# whose accept methods have no such guard. Remove it so Python adapts to PythonVisitor unconditionally, matching JS/C#.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Py.acceptshort-circuits any visitor whose class name starts withio.moderne.serialization.— returning the node unvisited — to avoid runtime visitor adaptation under a GraalVM native image. There is no native-image build anymore, so the guard is dead code.It is not harmless dead code, though. It silently stops
JavaVisitor-based tooling (search recipes, symbol indexing) from traversing a Python LST for those visitors, so they see nothing at all.JS.acceptandCs.acceptcarry no such guard, which is why the same tooling traverses JavaScript and C# but not Python. The check also hard-codes a downstream package name into the public tree.This removes the guard so Python adapts to
PythonVisitorunconditionally, exactly as JS and C# already do.